fix: deleted workspace room display in task share somewhere #41636

tienifr · 2024-05-04T08:51:49Z

Details

Deleted workspace room display in task's share somewhere list. This PR fixes that.

Fixed Issues

$ #41062
PROPOSAL: #41062 (comment)

Tests

Tap FAB > Assign task
Create a task and share in any workspace's #admins room
Delete that workspace
Tap FAB > Assign task
Open Share somewhere
Verify the above #admins room does not show

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Tap FAB > Assign task
Create a task and share in any workspace's #admins room
Delete that workspace
Tap FAB > Assign task
Open Share somewhere
Verify the above #admins room does not show

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

video_2024-05-04_16-27-13.mp4

Android: mWeb Chrome

video_2024-05-04_16-34-08.mp4

iOS: Native

Screen.Recording.2024-05-04.at.16.25.49-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-05-04.at.16.30.19-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-04.at.16.13.25-compressed.mov

MacOS: Desktop

Screen.Recording.2024-05-04.at.16.17.30-compressed.mov

melvin-bot · 2024-05-04T09:27:59Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-05-04T13:28:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

assignTaskAndroid.mp4

Android: mWeb Chrome

assignTaskAndroidChrome.mp4

iOS: Native

assignTaskiOS.mp4

iOS: mWeb Safari

assignTaskiOSSafari.mp4

MacOS: Chrome / Safari

assignTaskChrome.mp4

MacOS: Desktop

assignTaskDesktop.mp4

c3024 · 2024-05-04T15:45:41Z

src/components/OptionListContextProvider.tsx

-        if (replaceIndex === -1) {
-            return;
-        }
+        const newReports = OptionsListUtils.createOptionList({}, reports).reports;


Generating the whole optionList whenever any report changes looks inefficient. Can we just update the last three or five updated reports?

Updated. Deleting workspace is too buggy for me. I couldn't delete one. Even if so, the #admins and #accounce room are not archived.

I am sorry. I see that there can be many policy expense chats of other invited members as well. So just deleting 5 reports might not suffice because the other reports still appear in the results.

deleteFiveReports.mp4

c3024

LGTM

aldo-expensify · 2024-05-14T23:00:35Z

src/components/OptionListContextProvider.tsx


        setOptions((prevOptions) => {
            const newOptions = {...prevOptions};
-            newOptions.reports[replaceIndex] = newOption;


Just wanted to note that the old code was mutating data here which is pretty bad in React.

OSBotify · 2024-05-14T23:09:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-15T10:13:54Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.4.74-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dangrous · 2024-05-15T20:35:28Z

Looks like this had some side effects in other lists - #42189 (comment) - let me know what you think!

s77rt · 2024-05-16T00:49:23Z

src/components/OptionListContextProvider.tsx

-        if (replaceIndex === -1) {
-            return;
-        }
+        const newReports = OptionsListUtils.createOptionList({}, reports).reports;


Why we are passing empty object for the personal details? The personal details are used to get the correct icons. This is causing #42232. While testing I also found that the list becomes irresponsive and get into infinite loop (could be related to change here too?)

OSBotify · 2024-05-22T23:58:54Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

ahmedGaber93 · 2024-06-30T16:38:26Z

src/components/OptionListContextProvider.tsx

-
-        if (!lastUpdatedReport) {
-            return;
-        }


Removing the return early when no existing item need to update allow this useEffect to handle adding the new items which should handle in the next useEffect that lead to duplicated new items in the list, and it handled here #43094

deleted workspace room display in task share somewhere

2fc6f72

tienifr marked this pull request as ready for review May 4, 2024 09:27

tienifr requested a review from a team as a code owner May 4, 2024 09:27

melvin-bot bot requested review from c3024 and removed request for a team May 4, 2024 09:27

c3024 reviewed May 4, 2024

View reviewed changes

tienifr added 5 commits May 6, 2024 15:36

Merge branch 'main' of https://github.com/tienifr/App into fix/41062

4e00bd6

cache last 5 reports

3bbf651

fix test

a7a0f2b

Merge branch 'main' of https://github.com/tienifr/App into fix/41062

8fda27f

revert: cache last 5 reports

c7f128b

c3024 approved these changes May 9, 2024

View reviewed changes

melvin-bot bot requested a review from aldo-expensify May 9, 2024 17:57

aldo-expensify reviewed May 14, 2024

View reviewed changes

aldo-expensify approved these changes May 14, 2024

View reviewed changes

aldo-expensify merged commit 3e99a09 into Expensify:main May 14, 2024
18 checks passed

github-actions bot mentioned this pull request May 15, 2024

Deploy Checklist: New Expensify 2024-05-15 #42185

Closed

dangrous mentioned this pull request May 15, 2024

[HOLD for payment 2024-06-03] [$250] Start chat - No Recent section in Start chat list #42189

Closed

6 tasks

s77rt reviewed May 16, 2024

View reviewed changes

tienifr mentioned this pull request May 16, 2024

[CP Staging] fix: missing personal details while creating options list #42238

Merged

50 tasks

ahmedGaber93 mentioned this pull request Jun 5, 2024

[HOLD for payment 2024-06-28] [$250] [CRITICAL] [UX Reliability] The chat finder page shows duplicated result for a moment #43094

Closed

6 tasks

ahmedGaber93 mentioned this pull request Jun 14, 2024

Search result duplication #43164

Merged

50 tasks

ahmedGaber93 reviewed Jun 30, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: deleted workspace room display in task share somewhere #41636

fix: deleted workspace room display in task share somewhere #41636

tienifr commented May 4, 2024 •

edited

Loading

melvin-bot bot commented May 4, 2024

c3024 commented May 4, 2024 •

edited

Loading

c3024 May 4, 2024

tienifr May 6, 2024

c3024 May 7, 2024

tienifr May 8, 2024

c3024 left a comment

aldo-expensify May 14, 2024

OSBotify commented May 14, 2024

OSBotify commented May 15, 2024

dangrous commented May 15, 2024

s77rt May 16, 2024

OSBotify commented May 22, 2024

ahmedGaber93 Jun 30, 2024

fix: deleted workspace room display in task share somewhere #41636

fix: deleted workspace room display in task share somewhere #41636

Conversation

tienifr commented May 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 4, 2024

c3024 commented May 4, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 May 4, 2024

Choose a reason for hiding this comment

tienifr May 6, 2024

Choose a reason for hiding this comment

c3024 May 7, 2024

Choose a reason for hiding this comment

tienifr May 8, 2024

Choose a reason for hiding this comment

c3024 left a comment

Choose a reason for hiding this comment

aldo-expensify May 14, 2024

Choose a reason for hiding this comment

OSBotify commented May 14, 2024

OSBotify commented May 15, 2024

dangrous commented May 15, 2024

s77rt May 16, 2024

Choose a reason for hiding this comment

OSBotify commented May 22, 2024

ahmedGaber93 Jun 30, 2024

Choose a reason for hiding this comment

tienifr commented May 4, 2024 •

edited

Loading

c3024 commented May 4, 2024 •

edited

Loading